Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

haredo: enable cross compilation #312282

Merged
merged 1 commit into from
May 21, 2024

Conversation

onemoresuza
Copy link
Contributor

Description of changes

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:
  • haredo
  • haredo.man
  • treecat
  • treecat.man

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label May 16, 2024
@onemoresuza onemoresuza force-pushed the haredo-enable-cross-compilation branch from 576b8c2 to df7b060 Compare May 16, 2024 18:31
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3948

@onemoresuza onemoresuza force-pushed the haredo-enable-cross-compilation branch 2 times, most recently from 2a0a383 to a6bccfa Compare May 17, 2024 20:14
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

pkgs/by-name/ha/haredo/package.nix Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1668

@onemoresuza onemoresuza force-pushed the haredo-enable-cross-compilation branch from a6bccfa to b0960b5 Compare May 21, 2024 20:13
@pbsds pbsds merged commit 554e400 into NixOS:master May 21, 2024
23 of 24 checks passed
@onemoresuza onemoresuza deleted the haredo-enable-cross-compilation branch May 21, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants