nixos/hardware/printers: fix ppdOptions of ensured printers

[Yarny0]

Description of changes

#290240 changed the ensurePrinter mechanism such that it uses lib.cli.toGNUCommandLineShell. However, it missed to remove single quotes (') that have previously been needed to protect options from the shell, but that are now escaped and passed on to lpadmin, thereby breaking ppdOptions.

This pull request removes those superfluous quotes and fixes ppdOptions.

Notifying author of previous pull request: @rhoriguchi

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Note that this pull request does not affect any packages/tests.

Result of nixpkgs-review run on x86_64-linux 1

1 package blacklisted:

• nixos-install-tools

---

Add a 👍 reaction to pull requests you find important.

[rhoriguchi]

Hi @Yarny0 could you please post some test code so I can take a look.

[Yarny0]

This code

  services.printing.enable = true;
  services.printing.drivers = [ pkgs.foomatic-db-ppds ];
  hardware.printers.ensurePrinters = [{
    name = "myprinter";
    model = "foomatic-db-ppds/Samsung-ML-371x-Postscript-Samsung.ppd.gz";
    deviceUri = "socket://123.123.123.123:9100";
    ppdOptions.Duplex = "DuplexNoTumble";
  }];

should add a printer myprinter to your system. With current nixos-unstable branch, lpoptions -p myprinter -l will output

Duplex/Double-sided Printing: *None DuplexNoTumble DuplexTumble

i.e., the option was not used. With the pull request at hand applied, lpoptions -p myprinter -l will instead output

Duplex/Double-sided Printing: None *DuplexNoTumble DuplexTumble

showing that the option got applied properly.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3959

[Yarny0]

Thanks for the approval!

Now that 24.05 got branched off, can someone with sufficient privilegens please add the backport label, so we can avoid this regression in the upcoming release? Thanks!

[github-actions]

Successfully created backport PR for release-24.05:

• [Backport release-24.05] nixos/hardware/printers: fix ppdOptions of ensured printers #316696