Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofi-obsidian: init at 0.1.0 #312259

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

Nydragon
Copy link
Contributor

@Nydragon Nydragon commented May 16, 2024

Description of changes

rofi-obsidian is a plugin for rofi which allows launching specific Obsidian vaults via rofi.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@AndersonTorres if you could re-review, i'd greatly appreciate it


Add a 馃憤 reaction to pull requests you find important.

rofi-obsidian is a rofi plugin that allows opening vaults from rofi
@Nydragon
Copy link
Contributor Author

Related mr: #310269

@Aleksanaa Aleksanaa merged commit 9a50b22 into NixOS:master May 18, 2024
39 of 41 checks passed
@Nydragon
Copy link
Contributor Author

Thanks!

@Nydragon Nydragon deleted the init-rofi-obsidian branch May 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants