Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ablog: move to by-name, fix build and update #312250

Merged
merged 2 commits into from
May 24, 2024

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented May 16, 2024

Description of changes

ZHF #312250

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Signed-off-by: lucasew <lucas59356@gmail.com>
Signed-off-by: lucasew <lucas59356@gmail.com>
@lucasew
Copy link
Contributor Author

lucasew commented May 16, 2024

Result of nixpkgs-review pr 312250 run on x86_64-linux 1

2 packages built:
  • ablog
  • ablog.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3963

Copy link
Contributor

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 312250 run on x86_64-darwin 1

2 packages built:
  • ablog
  • ablog.dist

@mattpolzin mattpolzin mentioned this pull request May 21, 2024
13 tasks
@Aleksanaa Aleksanaa added the backport release-24.05 Backport PR automatically label May 24, 2024
@Aleksanaa Aleksanaa merged commit ef94c67 into NixOS:master May 24, 2024
32 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@lucasew lucasew deleted the 20240516-fix-ablog branch May 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants