Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #311923 to release 23.11 #312136

Merged
merged 3 commits into from
May 16, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented May 16, 2024

Description of changes

This is a manually created backport of #311923 that includes both a version bump, and some prior changes which added an update-script to the google-chrome package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@jnsgruk jnsgruk changed the title Backport 311923 to release 23.11 Backport #311923 to release 23.11 May 16, 2024
@ofborg ofborg bot requested a review from JohnRTitor May 16, 2024 06:35
@jnsgruk jnsgruk marked this pull request as ready for review May 16, 2024 08:07
@jnsgruk jnsgruk requested a review from emilylange May 16, 2024 08:07
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsgruk jnsgruk merged commit 58e1661 into NixOS:release-23.11 May 16, 2024
27 checks passed
@jnsgruk jnsgruk deleted the backport-311923-to-release-23.11 branch May 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants