linuxPackages.drbd: 9.2.8 -> 9.2.9 #312011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 6.8 kernel support added - aligned to Nix standard build environment - test added - redundant installPhase and postFixup definitions removed Signed-off-by: birkb <birk@batchworks.de>
birkb
requested review from
astro,
Thesola10 and
SuperSandro2000
and removed request for
astro
Thesola10
approved these changes
May 15, 2024
|
|
||
| src = fetchurl { | ||
| url = "https://pkg.linbit.com//downloads/drbd/9/drbd-${version}.tar.gz"; | ||
| hash = "sha256-LqK1lPucab7wKvcB4VKGdvBIq+K9XtuO2m0DP5XtK3M="; | ||
| url = "https://pkg.linbit.com//downloads/drbd/9/${finalAttrs.pname}-${finalAttrs.version}.tar.gz"; |
There was a problem hiding this comment.
Suggested change
| url = "https://pkg.linbit.com//downloads/drbd/9/${finalAttrs.pname}-${finalAttrs.version}.tar.gz"; | |
| url = "https://pkg.linbit.com//downloads/drbd/9/drbd-${finalAttrs.version}.tar.gz"; |
finalAttrs.pname is in many usecases wrong, as when we would append something like headless to pname, then the download URL would be broken
| @@ -0,0 +1,19 @@ | |||
| import ./make-test-python.nix ({ lib, pkgs, ... }: { | |||
| name = "drbd-driver"; | |||
| meta.maintainers = with pkgs.lib.maintainers; [ birkb ]; | |||
There was a problem hiding this comment.
Suggested change
| meta.maintainers = with pkgs.lib.maintainers; [ birkb ]; | |
| meta.maintainers = with lib.maintainers; [ birkb ]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.