Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wideriver: init at 1.1.0 #311935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wideriver: init at 1.1.0 #311935

wants to merge 1 commit into from

Conversation

clebs
Copy link
Member

@clebs clebs commented May 15, 2024

Description of changes

Closes #307238

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

yunfachi
yunfachi reviewed May 15, 2024
View reviewed changes
Copy link
Member

@yunfachi yunfachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maintainers: add clebs must be older than wideriver: init at 1.1.0.

pkgs/applications/window-managers/wideriver/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/wideriver/default.nix Outdated Show resolved Hide resolved
@clebs
Copy link
Member Author

clebs commented May 15, 2024 •
edited

@yunfachi do you mean I need to invert the order of my commits? (first add maintainers and then wideriver: init)

I rebased the 2 commits and squashed the suggestion into wideriver: init at 1.1.0

@clebs clebs requested a review from yunfachi May 15, 2024 13:38
tomodachi94

This comment was marked as resolved.

Sign in to view

@clebs clebs force-pushed the wideriver branch 2 times, most recently from 2668699 to 1757fea Compare May 20, 2024 20:22
tomodachi94
tomodachi94 suggested changes May 20, 2024
View reviewed changes
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
tomodachi94

This comment was marked as resolved.

Sign in to view

@clebs
Copy link
Member Author

clebs commented May 20, 2024

Thanks for the review and the helpful feedback @tomodachi94!

I moved the package and applied your suggestions.

Additionally, applied nixmft-rfc-style and made sure all items in the checklist under https://github.com/NixOS/nixpkgs/tree/master/pkgs#new-packages are met.

@clebs clebs requested a review from tomodachi94 May 20, 2024 20:58
@tomodachi94

This comment has been minimized.

Sign in to view
tomodachi94

This comment was marked as resolved.

Sign in to view

tomodachi94

This comment was marked as duplicate.

Sign in to view

tomodachi94
tomodachi94 approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving :) Thanks for the contribution! 鉂わ笍 馃殌

Edit: CI failures do not seem relevant to this PR, so this approval is sustained.

Gerg-L
Gerg-L reviewed May 23, 2024
View reviewed changes
pkgs/by-name/wi/wideriver/package.nix Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wi/wideriver/package.nix Outdated Show resolved Hide resolved
@clebs clebs requested a review from Gerg-L May 23, 2024 07:30
@clebs
Copy link
Member Author

clebs commented May 23, 2024

Hi @Gerg-L,
thanks for the review, I applied all suggestions. PTAL!

@Gerg-L
Copy link
Contributor

Gerg-L commented May 23, 2024

Result of nixpkgs-review pr 311935 run on x86_64-linux 1

1 package built:
  • wideriver

@Gerg-L
Copy link
Contributor

Gerg-L commented May 23, 2024

LGTM!

@Gerg-L
Copy link
Contributor

Gerg-L commented May 30, 2024

Result of nixpkgs-review pr 311935 run on x86_64-linux 1

1 package built:
  • wideriver

@clebs
wideriver: init at 1.1.0
4697088 
Signed-off-by: Borja Clemente <borja.clemente@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@tomodachi94 tomodachi94 tomodachi94 approved these changes

@Gerg-L Gerg-L Gerg-L approved these changes

@yunfachi yunfachi Awaiting requested review from yunfachi

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: wideriver
6 participants
@clebs @tomodachi94 @Gerg-L @Aleksanaa @yunfachi @wegank