ledger-udev-rules: 2021-09-10 -> 2024-02-12

[ToasterUwU]

Description of changes

This updates the udev rules that are needed for ledger live desktop to be able to connect to the ledger hardware. The current version of these udev rules no longer works.

The Ledger Live Desktop App couldn't connect to my Ledger Nano X.
I tried not using hardware.ledger.enable but instead adding the current rules from the official repo "manually" with service.udev.extraRules and that fixed the issue. Thats how i confirmed the outdated udev rules are the problem.

This is my first time contributing to Nix(OS), so im not sure i did everything right, but i certainly tried. If there are any issues, please guide me through them.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ToasterUwU]

Ok, i switched to my branch for my system to test if it works after reboot and all, and yes. This fixes the issue and there are no other issues caused by it as far as i can tell.

[ToasterUwU]

Im not sure if this needs backporting or not, so i will trust more experienced people with that decision, but i can confirm that on the current version of Ledger Live Desktop, the old udev rules are not working, so if the versions in stable are similar or the same, this should be backported as well.

[Scrumplex]

Im not sure if this needs backporting or not, so i will trust more experienced people with that decision, but i can confirm that on the current version of Ledger Live Desktop, the old udev rules are not working, so if the versions in stable are similar or the same, this should be backported as well.

Looking at the diff of the upstream repo, it seems like they refactored the rules but it seems like all devices should still work just as before.
https://github.com/LedgerHQ/udev-rules/compare/2776324af6df36c2af4d2e8e92a1c98c281117c9..f474382e370c9fa2a2207e6e675b9b364441aed7

I'd say this is a good candidate for backporting :D

[Scrumplex]

Result of nixpkgs-review pr 311899 run on x86_64-linux 1

1 package built:

• ledger-udev-rules

[asymmetric]

Thanks for the update -- a small change.

[asymmetric]

@ToasterUwU You need to change the date in the commit message as well (I know, so many details...) :)

[ToasterUwU]

Oops, got excited and forgot to double check.

Will do in a moment.

[ToasterUwU]

Ok, corrected the commit name as well. Should hopefully be good now

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] ledger-udev-rules: 2021-09-10 -> 2024-02-12 #312514