Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaom: don't disable runtime cpu detection on aarch64-darwin #311751

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 14, 2024

Description of changes

It seems to both work and be necessary now if we don't want to run into illegal instructions. Fixes #311623 for me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

it seems to both work and be necessary now if we don't want to
run into illegal instructions
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 14, 2024
@ofborg ofborg bot requested review from primeos, dali99 and kiloreux May 14, 2024 21:55
@emilytrau
Copy link
Member

emilytrau commented May 15, 2024

Would you please retarget this branch to master instead of staging-next
Oh this is related to ZHF? Please ignore 馃槄

@mweinelt mweinelt merged commit 2a949a0 into NixOS:staging-next May 15, 2024
28 checks passed
@mweinelt
Copy link
Member

Unclear why ofborg thinks this will be 0 rebuilds 馃し

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants