Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

miracode: init at 1.0 #311743

Merged
merged 2 commits into from
May 17, 2024
Merged

miracode: init at 1.0 #311743

merged 2 commits into from
May 17, 2024

Conversation

Coca162
Copy link
Contributor

@Coca162 Coca162 commented May 14, 2024

Description of changes

Miracode is a vectorized version of the Monocraft font.

Since this is my first contribution I am also adding myself to maintainer list!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! I've added some suggestions, but LGTM otherwise.

pkgs/by-name/mi/miracode/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mi/miracode/package.nix Outdated Show resolved Hide resolved
@Coca162
Copy link
Contributor Author

Coca162 commented May 15, 2024

Welcome! I've added some suggestions, but LGTM otherwise.

Thanks for the suggestions!

@Aleksanaa Aleksanaa changed the title Miracode: init at 1.0 miracode: init at 1.0 May 16, 2024
pkgs/by-name/mi/miracode/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/mi/miracode/package.nix Outdated Show resolved Hide resolved
@Aleksanaa Aleksanaa merged commit 85786b9 into NixOS:master May 17, 2024
25 checks passed
@Coca162 Coca162 deleted the miracode-1.0 branch May 17, 2024 08:23
@Hellodan1
Copy link

excellent work coca162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants