Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: allow running shellcheck on generated systemd scripts #311394

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented May 13, 2024

Description of changes

With this PR we run shellcheck on generated systemd scripts.
Our nixos closure already depends on GHC (and shellcheck), so this does not affect the runtime closure.

I fixed the scripts that I use on my machines, but there is definitely a lot more stuff to fix before this could become the default.

For now, this sits behind an enable-option. It would be great if some people would enable this and submit fixes for existing scripts.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@r-vdp r-vdp force-pushed the shellcheck_systemd_units branch from a9a7eb6 to e2a08b4 Compare May 13, 2024 15:13
@r-vdp r-vdp changed the title Run shellcheck on systemd scripts Allow running shellcheck on systemd scripts May 13, 2024
@r-vdp r-vdp changed the title Allow running shellcheck on systemd scripts Allow running shellcheck on generated systemd scripts May 13, 2024
@r-vdp r-vdp force-pushed the shellcheck_systemd_units branch from e2a08b4 to b3253bd Compare May 13, 2024 15:32
@r-vdp r-vdp changed the title Allow running shellcheck on generated systemd scripts systemd: allow running shellcheck on generated systemd scripts May 13, 2024
@r-vdp r-vdp force-pushed the shellcheck_systemd_units branch from 0ef7c54 to faf5a04 Compare May 13, 2024 19:00
@r-vdp r-vdp force-pushed the shellcheck_systemd_units branch from faf5a04 to cedb0c7 Compare May 13, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants