-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd: allow running shellcheck on generated systemd scripts #311394
Draft
r-vdp
wants to merge
13
commits into
NixOS:master
Choose a base branch
from
r-vdp:shellcheck_systemd_units
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-vdp
force-pushed
the
shellcheck_systemd_units
branch
from
May 13, 2024 15:13
a9a7eb6
to
e2a08b4
Compare
r-vdp
changed the title
Run shellcheck on systemd scripts
Allow running shellcheck on systemd scripts
May 13, 2024
r-vdp
changed the title
Allow running shellcheck on systemd scripts
Allow running shellcheck on generated systemd scripts
May 13, 2024
r-vdp
force-pushed
the
shellcheck_systemd_units
branch
from
May 13, 2024 15:32
e2a08b4
to
b3253bd
Compare
r-vdp
changed the title
Allow running shellcheck on generated systemd scripts
systemd: allow running shellcheck on generated systemd scripts
May 13, 2024
r-vdp
force-pushed
the
shellcheck_systemd_units
branch
from
May 13, 2024 19:00
0ef7c54
to
faf5a04
Compare
r-vdp
force-pushed
the
shellcheck_systemd_units
branch
from
May 13, 2024 20:57
faf5a04
to
cedb0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With this PR we run shellcheck on generated systemd scripts.
Our nixos closure already depends on GHC (and shellcheck), so this does not affect the runtime closure.
I fixed the scripts that I use on my machines, but there is definitely a lot more stuff to fix before this could become the default.
For now, this sits behind an enable-option. It would be great if some people would enable this and submit fixes for existing scripts.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.