Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] python311Packages.torch: add patches for CVE-2024-31580, CVE-2024-31583 & CVE-2024-31584 #311119

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 12, 2024

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2024-31580
https://nvd.nist.gov/vuln/detail/CVE-2024-31583
https://nvd.nist.gov/vuln/detail/CVE-2024-31584

Built about 100/300 nixpkgs-review packages on nixos x86_64 successfully before I ran out of time.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nbraud
Copy link
Contributor

nbraud commented May 22, 2024

@risicle If the rebuild takes so long, shouldn't this target staging-23.11 ?

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself seems OK, but the PR may need to be retargeted.

@risicle risicle force-pushed the ris-pytorch-CVE-2024-31580-CVE-2024-31583-r23.11 branch from 18c6bb4 to bf005bf Compare May 27, 2024 10:15
@risicle risicle changed the base branch from release-23.11 to staging-23.11 May 27, 2024 10:16
@risicle risicle merged commit 941dee2 into NixOS:staging-23.11 May 27, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants