Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.psycopg: 3.1.17 -> 3.1.19 #311009

Draft
wants to merge 1 commit into
base: staging-next
Choose a base branch
from
Draft

python3Packages.psycopg: 3.1.17 -> 3.1.19 #311009

wants to merge 1 commit into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 12, 2024

https://github.com/psycopg/psycopg/releases/tag/3.1.18
https://github.com/psycopg/psycopg/releases/tag/3.1.19

This turned out not to solve the regression in tests (current staging-next #309297)
https://hydra.nixos.org/build/258896597/nixlog/2/tail
but perhaps the updated patch can be reused in future.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@vcunat vcunat requested a review from mweinelt May 12, 2024 07:19
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 311009 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • khoj
  • khoj.dist
2 packages failed to build:
  • python311Packages.pytest-postgresql
  • python311Packages.pytest-postgresql.dist
31 packages built:
  • authentik
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • pgcli (python311Packages.pgcli)
  • pgcli.dist (python311Packages.pgcli.dist)
  • python311Packages.llama-index-vector-stores-postgres
  • python311Packages.llama-index-vector-stores-postgres.dist
  • python311Packages.mayim
  • python311Packages.mayim.dist
  • python311Packages.pgspecial
  • python311Packages.pgspecial.dist
  • python311Packages.pgvector
  • python311Packages.pgvector.dist
  • python311Packages.psycopg
  • python311Packages.psycopg.dist
  • python311Packages.psycopg.doc
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.mayim
  • python312Packages.mayim.dist
  • python312Packages.pgcli
  • python312Packages.pgcli.dist
  • python312Packages.pgspecial
  • python312Packages.pgspecial.dist
  • python312Packages.pgvector
  • python312Packages.pgvector.dist
  • python312Packages.psycopg
  • python312Packages.psycopg.dist
  • python312Packages.psycopg.doc

@mweinelt
Copy link
Member

Wouldn't say this is strictly a regression, it is mostly racy and I couldn't immediately reproduce locally.

@vcunat
Copy link
Member Author

vcunat commented May 12, 2024

Oh, the errors did reproduce for me in both versions, so that's why...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vcunat @mweinelt