[23.11] nanomq: add patches for CVE-2024-31040 & CVE-2024-31041 #310892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluiedev
approved these changes
May 12, 2024
|
Result of 1 package built:
|
LeSuisse
changed the title
LeSuisse
reviewed
May 13, 2024
There was a problem hiding this comment.
Builds and seems to work fine. However the tests seems to be failing which is not the case on top of release-23.11. Is there another patch missing?
Result of nixpkgs-review pr 310892 run on aarch64-linux 1
1 package built:
- nanomq
nanomq> Running phase: installCheckPhase
nanomq> mqtt v311 test start
nanomq> V4/V5 test passed!
nanomq> clean session test passed!
nanomq> Retain test passed!
nanomq> mqtt v311 test end
nanomq> mqtt v5 test start
nanomq> User property test passed!
nanomq> Shared subscription test passed!
nanomq> Sub client did not receive message * 10
nanomq> mosquitto_sub -h 127.0.0.1 -p 1883 -t 'topic'
nanomq> mosquitto_pub -h 127.0.0.1 -p 1883 -t topic -V 5 -m message -D Publish topic-alias 10 -d --repeat 10
nanomq> Topic alias test failed!
nanomq> mqtt v5 test failed
nanomq> 2024-05-13 11:42:43 [4064] WARN /build/source/nng/src/sp/transport/mqtt/broker_tcp.c:872: tcptran_pipe_recv_cb: recv error rv: 139
nanomq>
nanomq>
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/apps/broker.c:244: RECV ^^^^ ctx4 ^^^^
nanomq>
nanomq>
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1482: cmd: 3, retain: 0, qos: 0, dup: 0, remaining length: 116
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1530: topic: [$SYS/brokers/disconnected], len: [25], qos: 0
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1573: used pos: [27]
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1584: payload: [{"username":"(null)","ts":1715600563658,"reason_code":"8b","client_id":"nanomq-82ba5ab2"}], len = 89
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1170: pipe_info size: [0]
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:962: topic is: topic, node->topic is: topic
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:997: Search and delete client
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:998: node->topic:
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:81: ____________PRINT_DB_CLIENT___________
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:84: 1951111818
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:86:
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:88: ____________PRINT_DB_CLIENT___________
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:81: ____________PRINT_DB_CLIENT___________
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:84: 1951111818
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:86:
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nng/src/supplemental/nanolib/mqtt_db.c:88: ____________PRINT_DB_CLIENT___________
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/apps/broker.c:490: WAIT ^^^^ ctx4 ^^^^
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1266: free topic
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1282: free payload
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:1288: free pub_packet
nanomq>
nanomq> 2024-05-13 11:42:43 [4064] DEBUG /build/source/nanomq/pub_handler.c:86: pub_handler: init pipe_info
nanomq>
nanomq> Traceback (most recent call last):
nanomq> File "/build/source/.github/scripts/test.py", line 55, in <module>
nanomq> raise AssertionError
nanomq> AssertionError
|
The tests were already failing for me. |
|
Hum yeah indeed, I tried to rebuild the tests on top of release-23.11 and got a failure this time 馃し , let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2024-31040
https://nvd.nist.gov/vuln/detail/CVE-2024-31041
Unstable should be addressed by 0.21.9 which might happen in #284345
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.