zotify: init at 0.6.13 #310701
zotify: init at 0.6.13 #310701
Conversation
bwkam
force-pushed
the
init-zotify
branch
5 times, most recently
from
36b546a
to
672ff5e
Compare
bwkam
force-pushed
the
init-zotify
branch
8 times, most recently
from
6851326
to
f07ca35
Compare
bwkam
force-pushed
the
init-zotify
branch
2 times, most recently
from
73d1236
to
4d1239f
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3918 |
|
Last thing, did you use |
I think so. |
bwkam
force-pushed
the
init-zotify
branch
4 times, most recently
from
1101985
to
e95399f
Compare
pkgs/by-name/zo/zotify/package.nix
Outdated
| protobuf | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why do you disable tests here?
Also, please add pythonImportsCheck for a simple check.
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonimportscheck-using-pythonimportscheck
There was a problem hiding this comment.
There were no tests, but I guess I shouldn't have explicitly disabled it. I added pythonImportsCheck now.
|
|
||
| # Requires graphical environment to use pyautogui | ||
| doCheck = false; | ||
|
|
There was a problem hiding this comment.
Please add pythonImportsCheck.
bwkam
force-pushed
the
init-zotify
branch
2 times, most recently
from
9d16fbc
to
8a1cda8
Compare
| hash = "sha256-KA+Q4sk+riaFTybRQ3aO5lgPg4ECZE6G+By+x2uP/VM="; | ||
| }; | ||
|
|
||
| build-system = [ python3Packages.setuptools ]; |
There was a problem hiding this comment.
| build-system = [ python3Packages.setuptools ]; | |
| build-system = [ python3.pkgs.setuptools ]; |
or build-system = with python3.pkgs; [ setuptools ];...more of a personal preference.
There was a problem hiding this comment.
Unless python3.pkgs has been recently made to work with splicing, it isn't. The manual was specifically updated to advertise python3Packages instead of python3.pkgs: https://nixos.org/manual/nixpkgs/unstable/#buildpythonapplication-function
There was a problem hiding this comment.
In https://nixos.org/manual/nixpkgs/unstable/#buildpythonapplication-function there is no mention which approach is preferred or explanation why:
When packaging a Python application with buildPythonApplication, it should be called with callPackage and passed python3 or python3Packages (possibly specifying an interpreter version), like this:
The last part of that section says "python3 or python3Packages". As far as I remember is python3Packages.override still on the todo list.
There was a problem hiding this comment.
Sorry I wasn't more precise: 70aa345
There was a problem hiding this comment.
Link to the actual issue: #211340.
This still is not really documented, though
There was a problem hiding this comment.
I'm not sure which to use now. Most python packages I saw use python3Packages, so that's what I went with.
There was a problem hiding this comment.
I'm pretty confident that in the current situation we should keep python3Packages; @fabaff would be nice to receive a green light from you too just to know there's no conflict
EDIT(2024-06-02): I'll mark other instances of "python.pkgs v. pythonPackages" as "resolved" for now, to remove the visual noise; they can be "unresolved" later
Description of changes
Closes #310331
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.