-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
parinfer-rust-emacs: init at 0.4.6 #310468
Conversation
6dae0b5
to
88d1321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit message from parinfer-rust-emacs: init at v0.4.6
to parinfer-rust-emacs: init at 0.4.6
.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions
88d1321
to
7fa1724
Compare
@jian-lin All suggestions have been resolved, thanks for your guidance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, aside from the fingerprint formatting issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good except the format of fingerprint.
7fa1724
to
2990d58
Compare
2990d58
to
09665b2
Compare
Signed-off-by: Burgess Chang <bsc@brsvh.org>
Signed-off-by: Burgess Chang <bsc@brsvh.org>
09665b2
to
97d44a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks and welcome to the Nix family!
Description of changes
Add parinfer-rust-emacs v0.4.6, which is a fork of parinfer-rust (
kakounePlugins.parinfer-rust
).It will be useful for people who use
emacsPackages.parinfer-rust-mode
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.