Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

parinfer-rust-emacs: init at 0.4.6 #310468

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

brsvh
Copy link
Contributor

@brsvh brsvh commented May 10, 2024

Description of changes

Add parinfer-rust-emacs v0.4.6, which is a fork of parinfer-rust (kakounePlugins.parinfer-rust).

It will be useful for people who use emacsPackages.parinfer-rust-mode.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message from parinfer-rust-emacs: init at v0.4.6 to parinfer-rust-emacs: init at 0.4.6.

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/parinfer-rust-emacs/package.nix Outdated Show resolved Hide resolved
@jian-lin jian-lin changed the title Add parinfer-rust-emacs v0.4.6 parinfer-rust-emacs: init at 0.4.6 May 12, 2024
@brsvh
Copy link
Contributor Author

brsvh commented May 13, 2024

@jian-lin All suggestions have been resolved, thanks for your guidance :)

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from the fingerprint formatting issue

Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except the format of fingerprint.

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
brsvh added 2 commits May 16, 2024 17:52
Signed-off-by: Burgess Chang <bsc@brsvh.org>
Signed-off-by: Burgess Chang <bsc@brsvh.org>
Copy link
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks and welcome to the Nix family!

@jian-lin jian-lin merged commit a657d57 into NixOS:master May 16, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants