stdenv: log hooks as they run (take II) #310387
Open
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on latest staging |
|
I would recommend to wait for the next staging cycle as the current one is the last NixOS 24.05's one. |
philiptaron
approved these changes
May 11, 2024
xzfc
suggested changes
May 12, 2024
Qyriad
force-pushed
the
diag/log-hooks2
branch
2 times, most recently
from
c9dce8e
to
9919521
Compare
|
Now that the last staging cycle for 24.05 has been done, this PR should be ready |
philiptaron
approved these changes
May 23, 2024
xzfc
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A second take at #290081, which changes the stdenv builder to log setup and build hooks as they run, but which was reverted for the extra logging during the internals of
nix-shell -p. This PR does the same logging, but to $NIX_LOG_FD instead, which is echoed during any normal build, but not during the internals ofnix-shell -p.cc @philiptaron @RaitoBezarius from the last PR
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.