Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: Bump default version to v30 #309248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented May 5, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@yayayayaka
Copy link
Member Author

Result of nixpkgs-review pr 309248 run on x86_64-linux 1

1 package marked as broken and skipped:
  • itch
48 packages built:
  • affine
  • antares
  • bilibili
  • bitwarden-directory-connector
  • breitbandmessung
  • bruno
  • camunda-modeler
  • drawio
  • drawio-headless
  • electron
  • electron-bin
  • electron_29
  • electron_29-bin
  • fcast-receiver
  • freetube
  • geogebra6
  • headset
  • jitsi-meet-electron
  • koodo-reader
  • nix-tour
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • podman-desktop
  • pritunl-client
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • sharedown
  • standardnotes
  • stretchly
  • super-productivity
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • youtube-music
  • ytdownloader

Copy link
Member

@emilylange emilylange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because of #309041 (comment)

@drupol
Copy link
Contributor

drupol commented May 5, 2024

Can we rebase this PR ?

@emilylange
Copy link
Member

Can we rebase this PR ?

Why? What would change?

@drupol
Copy link
Contributor

drupol commented May 5, 2024

Blocking because of #309041 (comment)

This PR was merged , that's the reason why I requested the rebase. Am I misunderstanding something?

@emilylange
Copy link
Member

emilylange commented May 6, 2024

Blocking because of #309041 (comment)

This PR was merged , that's the reason why I requested the rebase. Am I misunderstanding something?

This PR here (#309248) was opened after #309041 had been merged.

And the reason I have a blocking review here, is because we need to fix #309041 (comment) (something I commented after #309041 had already been merged).

The easiest would be reverting 6a7a561 for now, until a newer version of electron_30 is released.
There is a whole history to it (unfortunately):

As of now, there is no consumer of electron_30 in nixpkgs (except #308970 I suppose).
This would obviously drastically change with this PR here, which, well, changes the default to electron_30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants