-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron: Bump default version to v30 #309248
base: master
Are you sure you want to change the base?
Conversation
Result of 1 package marked as broken and skipped:
48 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking because of #309041 (comment)
Can we rebase this PR ? |
Why? What would change? |
This PR was merged , that's the reason why I requested the rebase. Am I misunderstanding something? |
This PR here (#309248) was opened after #309041 had been merged. And the reason I have a blocking review here, is because we need to fix #309041 (comment) (something I commented after #309041 had already been merged). The easiest would be reverting 6a7a561 for now, until a newer version of As of now, there is no consumer of |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.