linuxPackages.drbd: 9.2.8 -> 9.2.9 #309022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 6.8 kernel support added - aligned to Nix standard build environment - test added - redundant installPhase and postFixup definitions removed Signed-off-by: birkb <birk@batchworks.de>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/linuxpackages-drbd-missing-system-map-file-skipping-depmod/44848/1 |
Signed-off-by: birkb <birk@batchworks.de>
Signed-off-by: birkb <birk@batchworks.de>
Thesola10
suggested changes
May 14, 2024
| @@ -266,6 +266,7 @@ in { | |||
| dovecot = handleTest ./dovecot.nix {}; | |||
| drawterm = discoverTests (import ./drawterm.nix); | |||
| drbd = handleTest ./drbd.nix {}; | |||
| drbd-driver = handleTest ./drbd-driver.nix {}; | |||
There was a problem hiding this comment.
The drbd test above uses the services.drbd.enable option, which already enables the kernel module. This test is redundant.
There was a problem hiding this comment.
The drbd test validates the userland utilities, but not the kernel driver. The in-tree driver is loaded to create the DRBD devices, but no special driver checks are done.
The drbd-driver test loads the out-of-tree driver (provided by this package) and validates the version of the loaded driver.
I think we need both tests...
astro
suggested changes
May 14, 2024
- for better readability Signed-off-by: birkb <birk@batchworks.de>
- 6.8 kernel support added - aligned to Nix standard build environment - test added - redundant installPhase and postFixup definitions removed Signed-off-by: birkb <birk@batchworks.de>
birkb
requested review from
mweinelt,
IvarWithoutBones,
mkg20001,
jtojnar,
mmahut,
RaghavSood,
aanderse,
drupol,
globin,
Ma27,
talyz and
figsoda
as code owners
birkb
requested review from
K900,
NickCao,
ttuegel,
dasJ,
RaitoBezarius,
Mic92,
zowoq and
a team
as code owners
github-actions
bot
added
6.topic: python
6.topic: GNOME
|
Mass ping, please resubmit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
installPhaseandpostFixupdefinitions removedThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)