Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 124.0.6367.91 -> 124.0.6367.118, lower version range of --ozone-platform-hint patch #308358

Merged
merged 2 commits into from
May 2, 2024

Conversation

emilylange
Copy link
Member

Description of changes

https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop_30.html

This update includes 2 security fixes.

CVEs:
CVE-2024-4331 CVE-2024-4368

Ref #306010

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Ref: fb10ea4

We had to apply this patch from M125 to M124 because at the time,
chromium hasn't backported this to M124 yet.

Until now!

Or at least somewhat.

124.0.6367.118 shipped and has an equivalent patch now, which means that
this patch is no longer needed.

(Ignoring the fact that it no longer applies because of this anyway)

At least on chromium.

The thing is, ungoogled-chromium hasn't caught up with chromium yet,
meaning it is still on < .118 and thus still needs that patch.
@emilylange emilylange changed the title chromium: 124.0.6367.91 -> 124.0.6367.118, remove --ozone-platform-hint patch again chromium: 124.0.6367.91 -> 124.0.6367.118, lower version range of --ozone-platform-hint patch May 2, 2024
@emilylange
Copy link
Member Author

Forgot about ungoogled-chromium not being in sync with chromium

@emilylange
Copy link
Member Author

Result of nixpkgs-review pr 308358 run on x86_64-linux 1

20 packages built:
  • aws-azure-login
  • chromium
  • chromium.sandbox
  • fast-cli
  • google-chrome
  • mermaid-cli
  • mermaid-filter
  • netflix
  • percollate
  • playwright-test
  • puppeteer-cli
  • python311Packages.pytest-playwright
  • python311Packages.pytest-playwright.dist
  • python312Packages.pytest-playwright
  • python312Packages.pytest-playwright.dist
  • sharedown
  • single-file-cli
  • sitespeed-io
  • vhs
  • wayback

Did some manual testing under wayland and the usual:

# git describe --abbrev=40
24.05-pre-68219-ge32981ab32c921f0506a3a560512e3a34726eafe
# nix-build -A stable nixos/tests/chromium.nix
/nix/store/4v39lx2gkvw7ffbp6k0zbbg6k5kfb12c-vm-test-run-chromium-stable

@emilylange emilylange merged commit 927faec into NixOS:master May 2, 2024
21 of 26 checks passed
@emilylange emilylange deleted the chromium branch May 2, 2024 00:52
Copy link
Contributor

github-actions bot commented May 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant