openssh: build with correct passwd path #308325
Conversation
|
As this is a change to openssh which requires massive rebuilds, the PR should go to staging. Marking as draft in the meantime. |
|
Just realised I did exactly what you said not to do. Will sort shortly. |
That was true in the past but we are now below 500 rebuilds which is generally fine to go master. The general rule of thumb is, that when the rebuild counts are red, it needs to to go to staging. |
|
Ok... so back against master then? |
wlcx
force-pushed
the
openssh-passwd
branch
2 times, most recently
from
359c282
to
abef7d1
Compare
| } // lib.optionalAttrs isNixos { | ||
| # openssh calls passwd to allow the user to reset an expired password, but nixos | ||
| # doesn't ship it at /usr/bin/passwd. | ||
| PATH_PASSWD_PROG = "/run/wrappers/bin/passwd"; |
There was a problem hiding this comment.
I always find it a bit cleaner to not use optionalAttrs for such things. We can probably place this inside of env and use optionalAttrs there. What do you think?
There was a problem hiding this comment.
Yeah, that's much nicer. Wasn't aware of env!
Description of changes
Tentative fix for #308247
Points openssh at nixos'
passwdso it can allow users to change expired passwords on loginnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.