Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox: fix for binary dropping version suffix #307681

Merged
merged 1 commit into from Apr 29, 2024

Conversation

nazarewk
Copy link
Member

@nazarewk nazarewk commented Apr 29, 2024

Description of changes

looks like the binary started appearing without version suffix in the derivation output. It's now just rambox instead of eg rambox-2.3.1, therefore symlink startes overriding that binary.

fixes #307545

Things done

skip symlink and use non-deprecated appimageTools attribute

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@eclairevoyant
Copy link
Member

The change in naming is likely related to #271071.
Thanks for the PR.

@eclairevoyant eclairevoyant merged commit 9e93dea into NixOS:master Apr 29, 2024
29 of 32 checks passed
@nazarewk nazarewk deleted the fix/rambox-binaries branch April 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rambox package broken
2 participants