Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ward: fix broken build #307318

Closed
wants to merge 1 commit into from

Conversation

YanniPapandreou
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This PR fixes a build error for the Python package ward which I was encountering on nixos-unstable. Part of the build error message is included below for refrence:

error: builder for '/nix/store/sp03is988s3jj6kmalp20c6ssmamcdmy-python3.11-ward-0.68.0b0.drv' failed with exit code 1;
       last 10 log lines:
       > * Getting build dependencies for wheel...
       > * Building wheel...
       > Successfully built ward-0.67.0b0-py3-none-any.whl
       > Finished creating a wheel...
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for ward-0.67.0b0-py3-none-any.whl
       >   - cucumber-tag-expressions<5.0.0,>=2.0.0 not satisfied by version 6.1.0
       >   - rich<13.0.0,>=12.2.0 not satisfied by version 13.7.1

I think there are two issues which this PR seeks to address:

  • The hash for version 0.68.0b0 of ward did not seem to be correctly specified and was loading in an older version of ward. I have updated the hash - this fixes the rich version constraint .
  • The version of cucumber-tag-expressions in nixpkgs unstable seems to be too up-to-date for the requirements of ward. I downgrade this to the version required by ward. Not sure if this is the best solution.

Add a 馃憤 reaction to pull requests you find important.

@@ -36,7 +36,15 @@ buildPythonPackage rec {
rich
tomli
pprintpp
cucumber-tag-expressions
(cucumber-tag-expressions.overridePythonAttrs (_: rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't override version for modules. if possible the constraint of cucumber-tag-expressions could be relaxed.

Otherwise we have to wait for upstream: darrenburns/ward#380

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks for opening an issue upstream! Could I try changing the version constraints in the derivation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants