Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/simplesamlphp: init #305981

Closed

Conversation

thenhnn
Copy link
Contributor

@thenhnn thenhnn commented Apr 22, 2024

Description of changes

Packaging of SimpleSAMLphp, an application written in native PHP that deals with authentication.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
pkgs/pkgs-lib/formats.nix Outdated Show resolved Hide resolved
@thenhnn thenhnn force-pushed the filesender-packaging-simplesamlphp-module branch 2 times, most recently from 0839d50 to 7ce9887 Compare April 25, 2024 07:02
@thenhnn thenhnn requested a review from infinisil April 27, 2024 15:03
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3905

@thenhnn thenhnn force-pushed the filesender-packaging-simplesamlphp-module branch from 7ce9887 to 0b28f26 Compare May 12, 2024 16:35
@thenhnn thenhnn force-pushed the filesender-packaging-simplesamlphp-module branch 2 times, most recently from 788d3c1 to 3378cb9 Compare May 12, 2024 16:37
@thenhnn thenhnn marked this pull request as draft May 13, 2024 08:49
@thenhnn thenhnn force-pushed the filesender-packaging-simplesamlphp-module branch from 3378cb9 to 1fad75b Compare May 16, 2024 14:58
@thenhnn thenhnn closed this May 16, 2024
@thenhnn thenhnn deleted the filesender-packaging-simplesamlphp-module branch May 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants