Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs/kde-pim: init #299599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 27, 2024

Description of changes

Closes #299152

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ShalokShalom
Copy link

In order to clarify the open question about how to install Kontact, Merkuro and standalone KMail etc:

Currently, it is planned to have them listed normally, and not activated by the service proposed here?

I think that would be a deviation from how things work in NixOS today.
What are the reasons for this?

I would rather choose between them as options of the service, as used to in other cases.

@ShalokShalom
Copy link

@SuperSandro2000 Does enabling programs.kde-pim by default mean Kontact will be installed on any Plasma 6 session, unless explicitly excluded?

@SuperSandro2000
Copy link
Member Author

It won't. I've added explicit options for kmail, kontact and mercuro in my latest push. I am not sure if that is the final design though.

Copy link
Contributor

@Shawn8901 Shawn8901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running that on my system since some days with kde-pim.enable and kde-pim.kmail, seems to work fine, so lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option "programs.kde-pim.enable"
5 participants