Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

betterbird: 115.6.0-bb21-correct-series-take2 -> 115.9.0-bb26-build2 #299026

Merged
merged 1 commit into from Mar 31, 2024
Merged

betterbird: 115.6.0-bb21-correct-series-take2 -> 115.9.0-bb26-build2 #299026

merged 1 commit into from Mar 31, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 25, 2024 •
edited

Closes #294238

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review March 25, 2024 22:00
@emilylange emilylange added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 26, 2024
LeSuisse
LeSuisse approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and starts correctly on Linux x86_64.

Result of nixpkgs-review pr 299026 run on x86_64-linux 1

2 packages built:
  • betterbird-unwrapped
  • betterbird-unwrapped.debug

@LeSuisse LeSuisse merged commit 54f9e01 into NixOS:master Mar 31, 2024
33 checks passed
@SuperSandro2000 SuperSandro2000 deleted the betterbird branch March 31, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

Assignees
No one assigned
Labels
1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: betterbird 115.6 → 115.8.1
3 participants
@SuperSandro2000 @LeSuisse @emilylange