Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-music: 3.3.1 -> 3.3.5 #299025

Merged
merged 1 commit into from Mar 30, 2024
Merged

youtube-music: 3.3.1 -> 3.3.5 #299025

merged 1 commit into from Mar 30, 2024

Conversation

SuperSandro2000
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Mar 25, 2024 •
edited

@ofborg build youtube-music

@ofborg ofborg bot requested a review from aacebedo March 25, 2024 23:03
@SuperSandro2000 SuperSandro2000 changed the title youtube-music: 3.3.1 -> 3.3.4 youtube-music: 3.3.1 -> 3.3.5 Mar 27, 2024
@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 299025 run on aarch64-darwin 1

1 package built:
  • youtube-music

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review March 27, 2024 20:24
@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 299025 run on x86_64-darwin 1

1 package built:
  • youtube-music

@SuperSandro2000 SuperSandro2000 merged commit def9bae into NixOS:master Mar 30, 2024
24 checks passed
@SuperSandro2000 SuperSandro2000 deleted the youtube-music branch March 30, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@aacebedo aacebedo Awaiting requested review from aacebedo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @khaneliman @wegank