Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pyzbar: don't propagate library with dev dependencies #298681

Merged
merged 1 commit into from Mar 31, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 24, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gador
Copy link
Contributor

gador commented Mar 31, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 298681 run on x86_64-linux 1

23 packages built:
  • gnome-frog
  • healthchecks
  • home-assistant-component-tests.devolo_home_network
  • home-assistant-component-tests.fritz
  • home-assistant-component-tests.fritzbox_callmonitor
  • home-assistant-component-tests.unifi
  • paperless-ngx
  • python311Packages.aiounifi
  • python311Packages.aiounifi.dist
  • python311Packages.devolo-plc-api
  • python311Packages.devolo-plc-api.dist
  • python311Packages.pyzbar
  • python311Packages.pyzbar.dist
  • python311Packages.segno
  • python311Packages.segno.dist
  • python312Packages.aiounifi
  • python312Packages.aiounifi.dist
  • python312Packages.devolo-plc-api
  • python312Packages.devolo-plc-api.dist
  • python312Packages.pyzbar
  • python312Packages.pyzbar.dist
  • python312Packages.segno
  • python312Packages.segno.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

gnome-frog:

got build log for '/nix/store/ghrf53c29ppzyvjp9qpf25m75brawcyp-gnome-frog-1.4.2' from 'daemon'
When evaluating attribute ‘gnome-frog’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/applications/misc/gnome-frog/default.nix:1:3:

  |
1 | { stdenv
  |   ^

warning: unused-argument
Unused argument: gtk4.
Near pkgs/applications/misc/gnome-frog/default.nix:6:3:

  |
6 | , gtk4
  |   ^
python311Packages.aiounifi.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

python311Packages.aiounifi:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

python312Packages.aiounifi.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

python312Packages.aiounifi:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

Copy link
Contributor

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Changes LGTM!

@SuperSandro2000 SuperSandro2000 merged commit b0cb3b1 into NixOS:master Mar 31, 2024
31 checks passed
@SuperSandro2000 SuperSandro2000 deleted the pyzbar-dev branch March 31, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants