New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix-ld-rs: init at 2024-03-23 #298607
nix-ld-rs: init at 2024-03-23 #298607
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-ld-rs-testers-wanted/42145/1 |
Maybe this would be a good point to also rework baseLibraries, so that any addition to it does not overwrite all default entries. https://github.com/NixOS/nixpkgs/blob/nixos-23.11/nixos/modules/programs/nix-ld.nix#L19C3-L19C17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode continues to work like before on WSL
Maybe they could be exposed as a readable option? Because there are cases where you want to override the default list. Anyway I find this is an orthogonal problem to the current PR, but keep the feedback in mind. |
If we set them in config, they could be overwritten completely with mkForce |
Feel free to make a pull request, but please also drop a release note item because nix-ld is widely used and this may be a surprising change. |
please see #299576 |
Description of changes
This pull requests add nix-ld-rs as an alternative implementation for nix-ld.
After a testing phase the plan is to merge nix-ld-rs into nix-ld.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.