Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-ld-rs: init at 2024-03-23 #298607

Merged
merged 3 commits into from Mar 25, 2024
Merged

nix-ld-rs: init at 2024-03-23 #298607

merged 3 commits into from Mar 25, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 24, 2024

Description of changes

This pull requests add nix-ld-rs as an alternative implementation for nix-ld.
After a testing phase the plan is to merge nix-ld-rs into nix-ld.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-ld-rs-testers-wanted/42145/1

@SuperSandro2000
Copy link
Member

Maybe this would be a good point to also rework baseLibraries, so that any addition to it does not overwrite all default entries. https://github.com/NixOS/nixpkgs/blob/nixos-23.11/nixos/modules/programs/nix-ld.nix#L19C3-L19C17

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode continues to work like before on WSL

@Mic92
Copy link
Member Author

Mic92 commented Mar 25, 2024

Maybe this would be a good point to also rework baseLibraries, so that any addition to it does not overwrite all default entries. https://github.com/NixOS/nixpkgs/blob/nixos-23.11/nixos/modules/programs/nix-ld.nix#L19C3-L19C17

Maybe they could be exposed as a readable option? Because there are cases where you want to override the default list. Anyway I find this is an orthogonal problem to the current PR, but keep the feedback in mind.

@Mic92 Mic92 merged commit ea50317 into NixOS:master Mar 25, 2024
47 checks passed
@Mic92 Mic92 deleted the nix-ld-rs branch March 25, 2024 13:52
@SuperSandro2000
Copy link
Member

If we set them in config, they could be overwritten completely with mkForce

@Mic92
Copy link
Member Author

Mic92 commented Mar 25, 2024

If we set them in config, they could be overwritten completely with mkForce

Feel free to make a pull request, but please also drop a release note item because nix-ld is widely used and this may be a surprising change.

@SuperSandro2000
Copy link
Member

please see #299576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants