Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra_unstable: strip to remove reference to build time only inputs #297295

Merged
merged 1 commit into from Mar 21, 2024

Conversation

SuperSandro2000
Copy link
Member

Description of changes

boehm-gc: -255.7 KiB
civetweb: -101.8 KiB
gnumake: -1541.7 KiB
hydra: -30043.8 KiB
nix: -660.7 KiB
prometheus-cpp: -59.4 KiB

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiffnLGTM, but haven't tested this change yet.

@SuperSandro2000
Copy link
Member Author

I've deployed this to my hydra and so far everything works like before

@Mindavi Mindavi merged commit 1c3379b into NixOS:master Mar 21, 2024
26 of 27 checks passed
@SuperSandro2000 SuperSandro2000 deleted the hydra-strip branch March 21, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants