Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

mindustry: fix build by downgrading jdk #297291

Merged
merged 1 commit into from Mar 21, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 19, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member Author

@ofborg build sweethome3d.application mindustry

@lucasew
Copy link
Contributor

lucasew commented Mar 20, 2024

Result of nixpkgs-review pr 297291 run on x86_64-linux 1

2 packages failed to build:
  • sweethome3d.furniture-editor
  • sweethome3d.textures-editor
4 packages built:
  • mindustry
  • mindustry-server
  • mindustry-wayland
  • sweethome3d.application

@bjornfor
Copy link
Contributor

sweethome3d was fixed like this (#296392) in the meantime. (Maybe that's a good option for mindustry too?)

@TomaSajt
Copy link
Contributor

sweethome3d was fixed like this (#296392) in the meantime. (Maybe that's a good option for mindustry too?)

It's not the same error, I believe. This build failure is because of a kotlin build error (some API changed in java 21 probably)

@wegank wegank changed the title sweethome3d: downgrade jdk to fix build, mindustry: fix build by downgrading jdk mindustry: fix build by downgrading jdk Mar 21, 2024
@SuperSandro2000 SuperSandro2000 merged commit 70d3286 into NixOS:master Mar 21, 2024
24 of 25 checks passed
@SuperSandro2000 SuperSandro2000 deleted the java-misc branch March 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants