New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devtoolbox: init at 1.1.1 (and dependencies) #295583
base: master
Are you sure you want to change the base?
Conversation
Not working:
Have bugs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you submit the patch upstream?
there seem to be tests for the python modules, can you add pytestCheckHook
and run the tests?
The upstream will eventually update the version of ramel_yaml, and they will change it at that time. The problem is that the ramel_yaml version they rely on is incompatible with the version in nixpkgs. The patch I wrote just makes it work, which may not be good enough, and upstream may not have plans to update it at this time.
Okay, I'll try it. |
pythonImportsCheck = [ | ||
"uuid6" | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please execute the tests https://github.com/oittaa/uuid6-python/tree/main/test
hash = "sha256-7Qr7OpcwV1dfmIMgG67+QCeHyl4R4dJON3GQ8MQ/GZM="; | ||
}; | ||
|
||
buildInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = [ | |
nativeBuildInputs = [ |
setuptools | ||
pyphen | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkPhase = '' | |
./test.py | |
''; | |
|
||
propagatedBuildInputs = [ | ||
setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propagatedBuildInputs = [ | |
setuptools | |
nativeBuildInputs = [ | |
setuptools | |
]; | |
propagatedBuildInputs = [ |
hash = "sha256-aokLCuQq6iHpC90MLCcIQxeEArPyx1o6RU1224xZdxY="; | ||
}; | ||
|
||
buildInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = [ | |
nativeBuildInputs = [ |
version = "0.1.5"; | ||
pname = "daltonlens"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "0.1.5"; | |
pname = "daltonlens"; | |
pname = "daltonlens"; | |
version = "0.1.5"; |
numpy | ||
pillow | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please execute the tests https://github.com/DaltonLens/DaltonLens-Python/tree/master/tests
]; | ||
mainProgram = "devtoolbox"; | ||
maintainers = with maintainers; [ aleksana ]; | ||
platforms = platforms.linux; # webkitgtk_6_0 is broken on darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platforms = platforms.linux; # webkitgtk_6_0 is broken on darwin |
but that is alread marked broken, is it? Then that propagates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: #295645 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a package is broken on a particular platform that is not a reason to mark all packages that depend on it broken for that platform.
python3Packages.buildPythonApplication rec { | ||
pname = "devtoolbox"; | ||
version = "1.1.1"; | ||
pyproject = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject = false; | |
pyproject = false; # uses meson |
# Upstream is using an incompatible version of ruamel.yaml | ||
# May be removed in next update | ||
patches = [ ./incompatible_ruamel_yaml.patch ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a commit we can fetch?
Description of changes
Tested
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.