wlx-overlay-s: init at 0.3.2 #292657
Merged
wlx-overlay-s: init at 0.3.2 #292657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolbinarycat
reviewed
Mar 5, 2024
Scrumplex
force-pushed
the
pkgs/wlx-overlay-s/init
branch
from
7152b3f
to
572a2a4
Compare
Scrumplex
force-pushed
the
pkgs/wlx-overlay-s/init
branch
2 times, most recently
from
0e2fc9a
to
eb9c056
Compare
Scrumplex
force-pushed
the
pkgs/wlx-overlay-s/init
branch
2 times, most recently
from
c2430ce
to
1d1cc54
Compare
Scrumplex
force-pushed
the
pkgs/wlx-overlay-s/init
branch
from
1d1cc54
to
207d8b5
Compare
Scrumplex
force-pushed
the
pkgs/wlx-overlay-s/init
branch
2 times, most recently
from
45f39e2
to
a4e7aa7
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3679 |
|
|
||
| postInstall = '' | ||
| wrapProgram $out/bin/wlx-overlay-s \ | ||
| --prefix LD_LIBRARY_PATH : ${ |
There was a problem hiding this comment.
Did you try doing this with patchelf?
There was a problem hiding this comment.
So using patchelf seems to work well here. I am not sure if there are more dynamic libraries out there depending on the environment, as I have only tested on Wayland myself.
I can imagine that libxkbcommon-x11.so or some X libraries are needed here too
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
pkgs/wlx-overlay-s/init
branch
from
a4e7aa7
to
0ac3540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/galister/wlx-overlay-s
WlxOverlay-S is a desktop overlay for OpenXR/OpenVR compositors
Linux aarch64 is currently broken because of some upstream crates using wrong data types.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.