Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpy-cli: init at 1.1.0 #291422

Merged
merged 1 commit into from Mar 29, 2024
Merged

httpy-cli: init at 1.1.0 #291422

merged 1 commit into from Mar 29, 2024

Conversation

hatch01
Copy link
Contributor

@hatch01 hatch01 commented Feb 25, 2024 •
edited

Description of changes

add the package httpy-cli

Things done

Create de derivation for httpy-cli.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

BCNelson
BCNelson suggested changes Feb 25, 2024
View reviewed changes
Copy link

@BCNelson BCNelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that you are doing version 1.0.0 rather than the version 1.1.0? Think that we should have the most resent version

AndersonTorres
AndersonTorres suggested changes Feb 25, 2024
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/httpy-cli/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/httpy-cli/default.nix Outdated Show resolved Hide resolved
@hatch01
Copy link
Contributor Author

hatch01 commented Feb 27, 2024

Is there a reason that you are doing version 1.0.0 rather than the version 1.1.0? Think that we should have the most resent version

It was a mistake because of releases on GitHub, but I switched to 1.1.0.

@BCNelson
Copy link

Okay I think you will need to update the git commit message and pr name. Then you are good to go.

@hatch01 hatch01 changed the title httpy-cli: init at 1.0.0 httpy-cli: init at 1.1.0 Feb 28, 2024
@hatch01
Copy link
Contributor Author

hatch01 commented Feb 28, 2024

Okay I think you will need to update the git commit message and pr name. Then you are good to go.

It's done

@hatch01
Copy link
Contributor Author

hatch01 commented Mar 22, 2024

@AndersonTorres does it look good now ?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3693

@hatch01 hatch01 force-pushed the httpy-cli branch 3 times, most recently from accbb5e to d7c0324 Compare March 27, 2024 09:51
@hatch01
Copy link
Contributor Author

hatch01 commented Mar 27, 2024

What do I need to wait for merge?

@drupol
Copy link
Contributor

drupol commented Mar 27, 2024

Let's wait for the CI tests to be completely finished and I'll merge it.

@hatch01 hatch01 force-pushed the httpy-cli branch 2 times, most recently from 21b6f1d to f02cb37 Compare March 28, 2024 07:35
@hatch01
Copy link
Contributor Author

hatch01 commented Mar 29, 2024

It seems complete to me now.

@drupol
Copy link
Contributor

drupol commented Mar 29, 2024

It seems complete to me now.

mmmh when I look at other python derivation, pythonImportsCheck only contains the module it is importing. Therefore, I would ask to only have httpy in pythonImportsCheck.

@hatch01
Copy link
Contributor Author

hatch01 commented Mar 29, 2024

Yeah, it seems better I have done it.

drupol
drupol approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks !

Waiting for the CI to be done before merging now.

@drupol drupol merged commit 770d703 into NixOS:master Mar 29, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@drupol drupol drupol approved these changes

@BCNelson BCNelson BCNelson approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 3+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hatch01 @BCNelson @nixos-discourse @drupol @AndersonTorres @SuperSandro2000 @delroth @wegank