Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

strictdoc: 0.0.40 -> 0.0.49 #288061

Merged
merged 1 commit into from Mar 20, 2024
Merged

strictdoc: 0.0.40 -> 0.0.49 #288061

merged 1 commit into from Mar 20, 2024

Conversation

ocfox
Copy link
Member

@ocfox ocfox commented Feb 11, 2024

Description of changes

will fix strictdoc build, see https://hydra.nixos.org/build/249200417
@yuuyins

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it on the Zephyr project requirements doc, works great! PR has a merge conflict, however.

@SuperSandro2000
Copy link
Member

@ocfox please rebase the PR

@ocfox ocfox changed the title strictdoc: 0.0.40 -> 0.0.47 strictdoc: 0.0.40 -> 0.0.49 Mar 20, 2024
@SuperSandro2000 SuperSandro2000 merged commit 9a64f4b into NixOS:master Mar 20, 2024
24 of 25 checks passed
@minijackson
Copy link
Member

@ocfox I think that during your migration of strictdoc to pkgs/by-name you forgot to remove the old pkgs/applications/science/engineering/strictdoc/ folder. Could you open a follow up PR? Feel free to tag me there for review to speeds things up.

@SuperSandro2000
Copy link
Member

#297738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants