rcu: init at 2024.001n #287775
Merged
rcu: init at 2024.001n #287775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPNA2608
force-pushed
the
init/rcu
branch
3 times, most recently
from
add96ae
to
08180ec
Compare
pkgs/by-name/rc/rcu/package.nix
Outdated
Comment on lines
128
to
130
| # Move post-wrapping shebanged main script to final location, replace with symlink | ||
| mv $out/bin/.rcu-wrapped $out/share/rcu/main.py | ||
| ln -s $out/share/rcu/main.py $out/bin/.rcu-wrapped |
There was a problem hiding this comment.
Why not create the wrapper manually and directly point to the main.py script?
There was a problem hiding this comment.
Implemented what I think you were asking for.
|
@ofborg build rcu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a package for the development version of reMarkable Connection Utility (RCU). It's FLOSS software, but not gratis, so purchased & downloaded source code must be provided by the user.
The intended way of building it seems incompatible with how we package python applications (Makefile constructs a venv & runs
pyinstallerto bundle everything into a single binary), so I'm just patching & moving the code to a separate directory. Seems to work fine.A patch is needed to make it compatible with our packaged version of paramiko (3.x), due to the following upstream changes:
I'm symlinking several non-code data files from the unpacked source into the final derivation, in an attempt to keep the src from being GC'd between system rebuilds: The download is quite slow, so I'd like to avoid redownloads as conveniently as possible.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.