Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microbin: import few fixes from PRs #266554

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

surfaceflinger
Copy link
Member

@surfaceflinger surfaceflinger commented Nov 10, 2023

Description of changes

Applied

Upstream seems inactive for now and these patches are fixing bugs that aren't just some edge cases.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/servers/microbin/default.nix Outdated Show resolved Hide resolved
pkgs/servers/microbin/default.nix Outdated Show resolved Hide resolved
@surfaceflinger surfaceflinger marked this pull request as draft November 11, 2023 19:31
@surfaceflinger surfaceflinger marked this pull request as ready for review November 11, 2023 21:04
@Artturin Artturin merged commit 9739c6c into NixOS:master Nov 18, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants