Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.jupyterlab-git: 0.42.0 -> 0.50.0rc0 #262742

Merged
merged 1 commit into from Nov 21, 2023
Merged

python311Packages.jupyterlab-git: 0.42.0 -> 0.50.0rc0 #262742

merged 1 commit into from Nov 21, 2023

Conversation

natsukium
Copy link
Member

@natsukium natsukium commented Oct 22, 2023 •
edited

Description of changes

Diff: jupyterlab/jupyterlab-git@v0.42.0...v0.50.0rc0

Changelog: https://github.com/jupyterlab/jupyterlab-git/blob/v0.50.0rc0/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

wait for v0.50.0
jupyterlab/jupyterlab-git#1236

@natsukium natsukium marked this pull request as draft October 27, 2023 13:40
kirillrdy
kirillrdy reviewed Nov 1, 2023
View reviewed changes
pkgs/development/python-modules/jupyterlab-git/default.nix Outdated
@@ -72,5 +78,7 @@ buildPythonPackage rec {
homepage = "https://github.com/jupyterlab/jupyterlab-git";
license = with licenses; [ bsd3 ];
maintainers = with maintainers; [ chiroptical ];
# https://github.com/jupyterlab/jupyterlab-git/issues/1245
Copy link
Member

@kirillrdy kirillrdy Nov 1, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.50.0a2 supports jupyerlab-4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will wait for the official release 0.50.0, but may adopt it in the ZHF.

@natsukium natsukium changed the title python311Packages.jupyterlab-git: mark as broken python311Packages.jupyterlab-git: 0.42.0 -> 0.50.0rc0 Nov 21, 2023
@natsukium natsukium marked this pull request as ready for review November 21, 2023 09:21
@natsukium natsukium added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label Nov 21, 2023
@natsukium
Copy link
Member Author

natsukium commented Nov 21, 2023 •
edited

Result of nixpkgs-review pr 262742 at 8dcd50a run on x86_64-linux 1

2 packages built successfully:
  • python310Packages.jupyterlab-git
  • python311Packages.jupyterlab-git

Result of nixpkgs-review pr 262742 at 8dcd50a run on aarch64-darwin 1

2 packages built successfully:
  • python310Packages.jupyterlab-git
  • python311Packages.jupyterlab-git

kirillrdy
kirillrdy approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 262742 run on aarch64-linux 1

4 packages built:
  • python310Packages.jupyterlab-git
  • python310Packages.jupyterlab-git.dist
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-git.dist

@natsukium natsukium merged commit 45d7c0e into NixOS:master Nov 21, 2023
25 checks passed
@natsukium natsukium deleted the jupyterlab-git/broken branch November 21, 2023 11:48
@natsukium
Copy link
Member Author

0.50.0 was just released.😇
https://github.com/jupyterlab/jupyterlab-git/releases/tag/v0.50.0

@natsukium natsukium mentioned this pull request Nov 22, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillrdy kirillrdy kirillrdy approved these changes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natsukium @kirillrdy