nixos/soju: add admin socket option and sojuctl wrapper #258520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-L
force-pushed
the
soju-admin-socket
branch
2 times, most recently
from
43fbdf7
to
90b5a26
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
and removed
2.status: merge conflict
labels
Benjamin-L
force-pushed
the
soju-admin-socket
branch
from
90b5a26
to
961ec39
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Benjamin-L
force-pushed
the
soju-admin-socket
branch
from
961ec39
to
a736a17
Compare
azahi
approved these changes
Nov 21, 2023
Benjamin-L
force-pushed
the
soju-admin-socket
branch
from
a736a17
to
d6e5c8e
Compare
Benjamin-L
force-pushed
the
soju-admin-socket
branch
from
d6e5c8e
to
68589b3
Compare
Benjamin-L
force-pushed
the
soju-admin-socket
branch
from
68589b3
to
4def374
Compare
|
CI failure is #301490, which is now fixed, but I don't think I have a way to retrigger job without pushing new commits. |
The config is a in an arbitrary nix store path, and is necessary to invoke sojuctl. Without the wrapper, you have to read the systemd unit or use a similar trick to find it.
For now, just try creating a user with sojuctl. Actually connecting an irc client is pretty annoying.
Benjamin-L
force-pushed
the
soju-admin-socket
branch
from
4def374
to
e9fed4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a
adminSocket.enableoption to theservices.sojumodule, a wrapper for thesojuctlcommand pointed at the service config file, and some tests.Using
sojuctlto create the first admin user is necessary when setting up asojuserver. Before these changes, doing this was pretty awkward. You have to do something like this:And then you need to find the config file path in the nix store by inspecting the systemd unit.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)