stork: 1.5.0 -> 1.6.0

[ElnuDev]

Description of changes

Updated stork from 1.5.0 to 1.6.0.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[ElnuDev]

I'm getting a weird build error for some reason.

       last 10 log lines:
       > ', stork-cli/src/pretty_print_search_results.rs:92:9
       > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       >
       >
       > failures:
       >     pretty_print_search_results::tests::display_pretty_search_results_given_output
       >
       > test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
       >
       > error: test failed, to rerun pass `-p stork-search --bin stork`

[wegank]

I'm getting a weird build error for some reason.

       last 10 log lines:
       > ', stork-cli/src/pretty_print_search_results.rs:92:9
       > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       >
       >
       > failures:
       >     pretty_print_search_results::tests::display_pretty_search_results_given_output
       >
       > test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
       >
       > error: test failed, to rerun pass `-p stork-search --bin stork`

jameslittle230/stork#338

Maybe skip this test and see if the binary works?

[ElnuDev]

I think this is blocking from a binary from being built with nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Is there a way to ignore Rust test failures?

It's getting late here so I'm going to go to sleep, I'll look into it more tomorrow.

[wegank]

Yes, see here.

[chuahou]

Since the test failure is not nix-specific, I've been waiting for an upstream response to the upstream issue rather than opting to disable to the test here. What do you think?

[ElnuDev]

Yes, see here.

I've skipped pretty_print_search_results::tests::display_pretty_search_results_given_output and the binary seems to work just fine.

It's been already a few weeks since the release of 1.6.0 and that issue, and there haven't been any updates on it yet. Wouldn't these test failures probably be fixed in the next release? Unless I'm missing something, I feel like it'd be better to get the package updated to 1.6.0 now, I mean the binary works.

[Artturin]

@ofborg build stork