Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iosevka: fix build and update 14.0.1 → 15.5.0 #176471

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

lunik1
Copy link
Contributor

@lunik1 lunik1 commented Jun 5, 2022

Description of changes

Updates iosevka to 15.5.0 and fixes build failure introduced in e6188b6 (see #176127).

Supersedes #175591 and #171439.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@LunNova LunNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the PR title but I don't think it matters once it's merged.

Confirmed the build was broken previously, and confirmed it builds now. :)

@lunik1 lunik1 changed the title iosevla: fix build and update 14.0.1 → 15.5.0 iosevka: fix build and update 14.0.1 → 15.5.0 Jun 5, 2022
@lunik1
Copy link
Contributor Author

lunik1 commented Jun 5, 2022

D'oh. Fixed now. Once ofborg has wrapped up it would be nice to get a fast merge on this, previous efforts have stalled out due to conflicts in node-packages.nix.

@happysalada
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants