Reviewer suggestions, second pass

NixOS · Apr 2, 2024 · c2c7fb2 · c2c7fb2
1 parent 03aa6f8
commit c2c7fb2
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkgs/by-name/rt/rtg-tools/package.nix b/pkgs/by-name/rt/rtg-tools/package.nix
@@ -1,7 +1,5 @@
 {
-  config,
   lib,
-  pkgs,
   stdenv,
   fetchFromGitHub,
   jdk,
@@ -24,18 +22,22 @@ stdenv.mkDerivation rec {
   nativeBuildInputs = [
     ant
     jdk
-    git
+    git # Required by build.xml to manage the build revision
     unzip
   ];
 
   buildPhase = ''
+    runHook preBuild
     ant rtg-tools.jar
+    runHook postBuild
   '';
 
   installPhase = ''
+    runHook preInstall
     mkdir -p $out/bin
     cp build/rtg-tools.jar $out/bin/RTG.jar
     cp installer/rtg $out/bin/
+    runHook postInstall
   '';
 
   postPatch = ''
@@ -48,7 +50,7 @@ stdenv.mkDerivation rec {
   '';
 
   meta = with lib; {
-    homepage = "https://github.com/RealTimeGenomics/rtg-tools/";
+    homepage = "https://github.com/RealTimeGenomics/rtg-tools";
     description = "Useful utilities for dealing with VCF files and sequence data, especially vcfeval";
     license = licenses.bsd2;
     platforms = [ "x86_64-linux" ];