Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dark theme #733

Merged
merged 6 commits into from Mar 6, 2024
Merged

Improve dark theme #733

merged 6 commits into from Mar 6, 2024

Conversation

zebreus
Copy link
Contributor

@zebreus zebreus commented Mar 5, 2024

This PR implements changes to the dark theme (#730) based on user feedback. A preview deployment is available at search.wirs.ing.

Feedback

I received the following feedback:

  • The header bar should have a different color than the main content
  • White text for everything has too much contrast
  • The sort dropdown should have a different background color
  • The results do not look like links because they are the same color as the text
  • Bad contrast of hovered links

This PR addresses all of these points.

Remarks

While the result is still not optimal, as now all text is grey, there is no easy fix for this. A better solution would be to redesign search.nixos.org to align its styling more closely with nixos.org, but that would require a lot more work.

@zebreus zebreus mentioned this pull request Mar 5, 2024
@garbas garbas merged commit b8edfd2 into NixOS:main Mar 6, 2024
2 checks passed
@SuperSandro2000
Copy link
Member

Now it feels a lot better already. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants