New hardware config: Surface Pro 9 #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iwanders I recall you have an SP9. Do you have thoughts on disabling PSR by default? |
|
Yeah, I have an SP9, I also have this option disabled, for me it mostly appeared as if the screen was flickering (Wayland, Gnome 45). So yeah, good change imo. |
tracteurblinde
approved these changes
May 15, 2024
Mic92
reviewed
May 19, 2024
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d789d9a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a fairly minor change to disable an Intel GPU feature called Panel Self Refresh (PSR). This option ostensibly increases battery life by letting the display refresh independently, but it causes a lot of display lag and stuttering, even on Windows. This PR proposes to disable this feature by default so folks have a usable out-of-the-box experience at the cost of a little battery life.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input: https://github.com/8bitbuddhist/nix-configuration/blob/main/flake.nix#L110