Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.21-maintenance] build-remote: fix format string shenanigans #10328

Merged
merged 1 commit into from Mar 26, 2024
Merged

[Backport 2.21-maintenance] build-remote: fix format string shenanigans #10328

merged 1 commit into from Mar 26, 2024

Conversation

github-actions[bot]
Copy link

Automatic backport to 2.21-maintenance, triggered by a label in #10325.

@K900 @github-actions
build-remote: fix format string shenanigans
fb25bdc 
HintFmt(string) invokes the HintFmt("%s", literal) constructor,
which is not what we want here. Add a constructor with a proper name
and call that.

Next step: rename all the other ones to HintFmt::literal(string).

Fixes #10238

(cherry picked from commit 2d4edb9)
@github-actions github-actions bot requested a review from edolstra as a code owner March 26, 2024 13:35
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
@thufschmitt thufschmitt reopened this Mar 26, 2024
@thufschmitt thufschmitt merged commit 3272ed0 into 2.21-maintenance Mar 26, 2024
9 checks passed
@edolstra edolstra deleted the backport-10325-to-2.21-maintenance branch March 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thufschmitt @K900