Minor improvements #968
Merged
Minor improvements #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdietl
force-pushed
the
pdietl/nixos-modules-improvements
branch
2 times, most recently
from
5f7386d
to
a307fd1
Compare
pdietl
force-pushed
the
pdietl/nixos-modules-improvements
branch
from
a307fd1
to
f5c0378
Compare
|
Nice! Though Git doesn't detect the files as having been renamed. To fix this, could you split this into at least two commits, the first one that just renames the files, the second changing them? That should make reviewing easier :) |
fricklerhandwerk
force-pushed
the
pdietl/nixos-modules-improvements
branch
from
f5c0378
to
99d2f91
Compare
|
@infinisil I did the history rewrite. |
fricklerhandwerk
force-pushed
the
pdietl/nixos-modules-improvements
branch
from
99d2f91
to
dfec330
Compare
added 2 commits
May 14, 2024 22:56
Rename `map` to `map.sh` and `geocode` to `geocode.sh` in hopes that when downloading, Google Chrome doesn't automatically add a `.txt` extension.
Add more error checking to the `map.sh` and `geocode.sh` script The default zoom of 2 results in the `center` option not showing anything different. So, we change the default zoom to 10. We also clear up the fact that using an option type of `nullOr <blah>` does not set a default value of `null` for you.
fricklerhandwerk
force-pushed
the
pdietl/nixos-modules-improvements
branch
from
dfec330
to
0b3e512
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-05-14-documentation-team-meeting-notes-126/45431/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more error checking to the
mapandgeocodescriptRename
maptomap.shandgeocodetogeocode.shin hopes thatwhen downloading, Google Chrome doesn't automatically add a
.txtextension.The default zoom of 2 results in the
centeroption not showing anythingdifferent. So, we change the default zoom to 10.
We also clear up the fact that using an option type of
nullOr <blah>does notset a default value of
nullfor you.