Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sourcemap issue #13

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

gabrielstellini
Copy link

@gabrielstellini gabrielstellini commented Oct 15, 2023

Problem Description:

In the context of a Svelte project, the library produced a warning as demonstrated below:
image (1)

Proposed Changes:

  • The source code has been incorporated into the published bundle to resolve the aforementioned warning.
  • Updates have been made to the .gitignore file to prevent unintentional publication of IDE-specific files and .npmrc.

Verification:

The changes were tested by:

  • running npm pack followed by extraction of the resultant tarball into the node_modules directory of the respective Svelte project.
  • running npm publish --dry-run; verifying the files for accuracy.

@NishuGoel NishuGoel merged commit a0859d9 into NishuGoel:main Oct 15, 2023
2 checks passed
@gabrielstellini
Copy link
Author

@NishuGoel Would it be possible to release a new version with this change on npm?

@NishuGoel
Copy link
Owner

Its live! 💪 thanks!

@gabrielstellini
Copy link
Author

gabrielstellini commented Oct 19, 2023

@NishuGoel I believe there's an issue in the github action configuration. It was marked as successful, even though it failed to publish https://github.com/NishuGoel/svelte-i18next/actions/runs/6571220786/job/17849970826

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants