Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iPhone 15 series of devices. #89

Merged
merged 3 commits into from Sep 15, 2023
Merged

Support iPhone 15 series of devices. #89

merged 3 commits into from Sep 15, 2023

Conversation

vincentneo
Copy link
Collaborator

It's that Time of the year again!

Also: Previously, DeviceModel.hasNotch will return true for Dynamic Island devices like the iPhone 14 Pro. In this pull request, that will no longer be true, as there's a new DeviceModel.hasDynamicIsland, specific for that use case.

Tests have also been updated to reflect the changes of this pull request.

@Nirma Nirma self-requested a review September 15, 2023 08:03
Copy link
Owner

@Nirma Nirma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nirma Nirma merged commit 51c1070 into main Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants