New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Watch devices support #88
Conversation
@vincentneo I am so sorry for replying late! Yes lets add in watchOS support. I think we can add a watchOS target for both SPM and CocoaPods and use symlinks to smooth out any rough edges. For now this looks good, let me update the CI settings. By the way what are you concerned with on this point?
|
Tried adding in another Package.swift (since the watch codes are on separate directories), doesn't seem to work. So my only concern is that it couldn't be packaged correctly that's all! |
Thinking it through, maybe we can just throw a bunch of |
Have implemented this. Code now looks like a mess, but (1) it works fine (tested on simulator), (2) SPM easily cooperates with this. @Nirma What do you think about this? Wish to hear some thoughts on this, before I write the test cases. |
@vincentneo Yes, it looks fine to me. Lets roll with it. |
Have written the tests, let me know if I missed out on something, thanks! |
@vincentneo LGTM! |
Hey @Nirma,
Recently needed something like
UIDeviceComplete
but for the Apple Watch, so I wrote this.I've added a bunch of code for a separate target in the Xcode project, called
WKDeviceComplete
.Currently:
But otherwise, the code does work. Only
System.swift
is shared.Usage wise, it's pretty similar:
I'm unsure if this should belong as a fork of
UIDeviceComplete
instead (because of SPM, etc). What do you think?