Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

124 apps as modules #349

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from
Open

124 apps as modules #349

wants to merge 32 commits into from

Conversation

stian-johnsen
Copy link
Collaborator

@stian-johnsen stian-johnsen commented May 16, 2019

Status

Testing

Description

This PR covers the changes proposed in tickets #346 and #124. It introduces a module wrapper allowing for the running of NiftyNet applications in 3rd-party code, and a set of changes that enable the input from and output to memory of images.
The code is known to work for segmentation and regression applications. However, the changes made to the GAN, classification, and registration applications have not been tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Impacted Areas in Application

List general components of the application that this PR will affect:

  • niftynet.io.*
  • niftynet.application.*
  • niftynet.layer (preprocessing layers)
  • demos

@wyli wyli self-assigned this May 16, 2019
@mmodat mmodat moved this from To do to In progress in NiftyNet Hackathon Preparation May 23, 2019
@ericspod
Copy link
Collaborator

ericspod commented Jun 4, 2019

This has to be left to last as it involves a lot of file changes. Other PRs and issues must be resolved first.

@ericspod ericspod self-assigned this Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants